feat(issue-views): Change add view button to just + icon near starred views header' #87360
Conversation
github-actions
bot
added
the
Scope: Frontend
| height: 14px !important; | ||
| margin: 0 !important; |
There was a problem hiding this comment.
Idk why but there are top level sentry.css styles that are forcing margin and height properties on the loadingindicator.mini class.
There was a problem hiding this comment.
Ugh I hate when we run into high specificity CSS styles
There was a problem hiding this comment.
I wonder if adding mini is conflicting with the height prop you're sending?
There was a problem hiding this comment.
It might, but mini also controls the width of the loading ring. Without it here, the width looks too big relative to the space its contained in.
| @@ -149,12 +151,13 @@ export function IssueViewNavItemContent({ | |||
| dragListener={false} | |||
| dragControls={controls} | |||
| style={{ | |||
| ...(isDragging | |||
| ...(isDragging || scrollPosition === 0 | |||
There was a problem hiding this comment.
This kinda fixes that really annoying issue where views wouldn't animate in and out as a result of the originY styles. We only need to apply those styles if the user has scrolled down on the page, since that's what triggers the framer motion bug.
There was a problem hiding this comment.
Would be nice to add a comment here about why this is necessary since it will be very confusing to future readers!
| position: relative; | ||
| background-color: ${p => p.theme.translucentSurface200}; | ||
| background-color: ${p => (p.grabbing ? p.theme.translucentSurface200 : 'transparent')}; |
There was a problem hiding this comment.
Views had a slightly different background in their resting state. This applies the translucent border only when dragging.
| <SecondaryNav.Section | ||
| title={ | ||
| <TitleWrapper> | ||
| {t('Starred Views')} | ||
| <IssueViewAddViewButton baseUrl={baseUrl} /> | ||
| </TitleWrapper> | ||
| } | ||
| > |
There was a problem hiding this comment.
This is moved in from navigation.tsx
static/app/components/nav/issueViews/issueViewAddViewButton.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Malachi Willey <[email protected]>
Moves the Add View Button from below the views to the right of the "Starred Views" header. Adds a tooltip that says "Add View"
Before:
After:
Includes a couple of annotated drive by changes that aren't super related